Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rake npm:ruby-head-wasm-wasicurrently forces a Ruby rebuild on every run, repeating linking and Asyncify even when the statically linked gem extensions have not changed.Add an
ExtensionCachethat uses the existing extensioncache_keymethods and stores the input hash beside the Ruby archive. Reuse the archive when the hash matches, and remove the unconditional--remakefrom npm packaging. Explicit--remake,--reconfigure, and--cleanstill force a build.Invalidate the previous record before building, and save a new record only after a successful build whose extension inputs stayed unchanged. Existing archives with extensions but no record are rebuilt once; archives without extra extensions retain their existing reuse behavior. Ruby source, compiler, and build-setting changes still require a manual rebuild.
Validation
bundle exec steep check: passed.ruby-head-wasm-wasipackage built successfully. WithBINARYEN_CORES=1, a rebuilding run took 3m52.19s and a repeated run took 46.78s; both Ruby packaging invocations reused the archive on the repeated run.