Repository navigation
Ignore None consistently in URI template list expansions - #161
Open
machines-6657 wants to merge 2 commits into
Open
machines-6657 wants to merge 2 commits into
machines-6657 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignore
Noneconsistently when expanding list arguments. The 3.0.1 changelogdocuments this behavior, but simple/reserved/fragment, query/continuation and
non-exploded semicolon expansions still include the literal text
None.For example,
{?x}withx=["a", None, "b"]currently produces?x=a,None,b; the corrected expansion is?x=a,b.The filters use
is not None, preserving defined empty strings and numeric zeroand leaving the caller's list unchanged. Regression coverage includes all 16
operator/explode forms, empty/zero controls and mutation checks. Existing empty
collection and mapping behavior is outside this change.
Validation
failing subtests; the mutation controls pass.
git diff --checkpassed.AI assistance was used to investigate, implement and verify this change.