Repository navigation
Conversation
Keep the moved descendant attached to its own children during cycle avoidance, as required by RFC 7540 section 5.3.3. Cover direct and indirect descendants with exclusive and nonexclusive dependencies, including child-list and queue consistency. Generated with OpenAI Codex and independently reviewed by a native AI agent. No human review or certification is claimed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reprioritizing a stream beneath one of its descendants currently promotes the descendant's children to its old parent while leaving them in the descendant's child list and scheduling queue. In RFC 7540 section 5.3.3, Figure 5, moving A beneath D incorrectly leaves F attached to C instead of D. Exclusive reprioritization also leaves duplicate child ownership.
Pass
strip_children=Falsewhen moving the descendant to avoid the cycle. This preserves the subtree until the existing exclusive/nonexclusive insertion logic runs. The regression covers direct and indirect descendants, both exclusive modes, parent pointers, child lists, scheduling queues, and scheduling output.Validation:
532ace514de40ebf9a9c0a4418cbfb0e72c8f7a4: 170 tests passed with 100% coverage; all four new regression cases fail against that base.src/priority/__init__.pyand the imports intest/test_priority.py; the same formatting failures reproduce on the unchanged base. No added lines are flagged. The remaining interpreter matrix was not run locally. Hosted CI is awaiting maintainer approval; no hosted jobs have run.AI assistance was used to prepare implementation and regression tests.