Repository navigation
Conversation
…'s end. The loop tested the cursor pointer, not the slot, so it never stopped on the NULL terminator. It now counts off zend_flf_count, and the caller advances instead of spinning on continue.
devnexen
marked this pull request as ready for review
August 30, 2026 20:52
ndossche
reviewed
Oct 17, 2026
| { | ||
| void **handlers = zend_flf_handlers; | ||
| void **current = handlers; | ||
| while (current) { |
Member
There was a problem hiding this comment.
So why not change this to *current ? Seems nicer than rewriting the code (which would avoid an induction loop variable)
| || frameless_function_info->num_args == args->children)) { | ||
| uint32_t num_args = frameless_function_info->num_args; | ||
| uint32_t offset = find_frameless_function_offset(num_args, frameless_function_info->handler); | ||
| if (offset == (uint32_t)-1) { |
Member
Author
There was a problem hiding this comment.
kind of is yes, frameless_function_info increment sits at the bottom of the while part, previously continue skipped it, before vs now: -1 as return could not happen, with *current it now can.
| current++; | ||
| } | ||
|
|
||
| /* Unreachable in practice: zend_register_functions() records the handler |
ndossche
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…'s end.
The loop tested the cursor pointer, not the slot, so it never stopped on the NULL terminator. It now counts off zend_flf_count, and the caller advances instead of spinning on continue.