Repository navigation
Set alembic path_separator and pin postgres 17 - #93
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
path_separator = ostoalembic.ini, as chat-app already does. Alembic 1.16+ emitted a DeprecationWarning on every run, visible in the pytest-alembic suite.postgres:17in both.github/workflows/main.yml(waslatest) anddocker-compose.yml(was14), matching chat-app.Why
CI and local compose ran different Postgres majors, so a migration could pass in one and fail in the other. Both now use 17.
Testing
Config-only change, so no new test. Checked locally against a Postgres 17 container:
tests/migrationspasses, and thepath_separatorDeprecationWarning is gone (5 warnings before, none after).