Repository navigation
fix: require deck_id on Card response schema - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cards.deck_idis NOT NULL in the model and the database after #91, soCard.deck_idin the API schema should be required instead ofPositiveInt | None = None.Cardwas also the body type ofPUT /api/decks/{deck_id}/cards/, where the deck comes from the path and the repository already dropped any bodydeck_id. Making the field required would have made every PUT fail validation, so the body now uses a newCardUpdate(front, back, hint, id).Cardextends it with the requireddeck_idand is used for responses only.upsert_cardsno longer needsexclude={"deck_id"}.Tests: a new OpenAPI test asserts
deck_idis required onCard. It failed before the change. Ruff, ty and pytest (100% coverage) pass against Postgres 14.