Repository navigation
Conversation
graphql-codegen resolves plugin names from the project root, so the typed-document-node plugin declared in codegen.ts must be a declared dependency. It was previously reachable only through the removed hoisted pnpm layout, which broke pnpm codegen under the default isolated linker. OpenSpec change: fix-graphql-codegen-plugin-resolution
…apshot graphql.config.ts referenced a schema file codegen no longer produced and a documents glob in a directory that no longer existed, so the VS Code GraphQL extension had no schema. - Re-add a schema-ast output to codegen.ts, writing schema.graphql next to the generated types. - Point graphql.config.ts at the committed snapshot and the current GitHub documents. - Un-ignore the snapshot so it is committed alongside the operation types. Stacked on #3450, which is required for pnpm codegen to run. OpenSpec change: repair-graphql-lsp-config
Base automatically changed from
fix/graphql-codegen-plugin-resolution
to
main
October 17, 2026 04:01
github-actions
Bot
added
bug
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
graphql.config.ts— the config the VS Code GraphQL extension reads — pointed at both:schemafile codegen stopped producing, anddocumentsglob in a directory that no longer exists (documents moved tosrc/renderer/utils/forges/github/).The language server therefore had no schema to validate against, and the path could not be fixed by editing it alone — the file was never produced.
What changed
codegen.ts: add aschema-astoutput writingschema.graphqlnext to the generated operation types (reuses the already-installed@graphql-codegen/schema-ast).graphql.config.ts: pointschemaat the committed snapshot anddocumentsatsrc/renderer/utils/forges/github/**/*.graphql. Bitbucket documents target a different schema and stay excluded..gitignore: un-ignore the snapshot via a targeted negation, mirroring the existing screenshot-baseline pattern.Verification
pnpm codegenwrites the snapshot; the generatedgraphql.tsis unchanged.graphql-configwithGITHUB_TOKENunset: schema resolves from the local snapshot (1839 types), documents = the 5 GitHub operations, 0 SDL definitions.pnpm checkpasses.Stacking
Based on
fix/graphql-codegen-plugin-resolution(#3450) becausepnpm codegencannot run until that dependency fix lands. When #3450 merges, this PR retargets tomainautomatically.OpenSpec change:
repair-graphql-lsp-config