Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
🟢 Approval recommended
The development-only extraction preserves existing checks and has no blocking issues.
0 open findings
What changed in this PR
Extracts the diagnostics-export workflow’s inline checks into TypeScript, preparing the development-only test for #4223.
Changes:
- Moves existing SARIF assertions into a standalone script with explicit missing-field checks.
- Enables Node setup and runs the script with
tsx.
| File | Description |
|---|---|
pr-checks/checks/diagnostics-export.yml |
Replaces the inline script with TypeScript execution. |
pr-checks/check-diagnostics.ts |
Contains the extracted diagnostic assertions. |
Files excluded by content exclusion policy (1)
- .github/workflows/__diagnostics-export.yml
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mbg
added this pull request to stack #4250
October 16, 2026 16:13
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple dev-only change in prep for #4223 which moves the inline script out of the
diagnostics-export.ymlworkflow and into a TS file, along with some minor changes to make TS happy.