Skip to content

Point five stale S2 references at what exists - #717

Merged
derek73 merged 1 commit into
masterfrom
fix/s2-stale-pointers
Oct 18, 2026
Merged

derek73 merged 1 commit into
masterfrom
fix/s2-stale-pointers

Conversation

@derek73

@derek73 derek73 commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Follow-up to #716 (#682). Five references the S2 split's reviews found were already stale before the split. Comments only; no behavior change.

  • _pieces.py, test_group.py, cases.py credited "rules/S2's initial veto", and test_policy.py "rules/S2's numeral fork". No rule's statement holds either clause, before or after the split.
    • The comma case is rules/C1's one-character suffix word, read by what stands before it, and the _pieces docstring now cites that.
    • The others now name the predicates: _vocab.is_initial and _vocab.is_trailing_numeral_suffix.
  • cases.py's "row item 5 of decisions/S4" pointed at a numbered list in a gitignored spec. It now names the decisions/S4 entry it meant: 2026-09-15, THE COUNT REACHES THE LISTED SET TOO, which names Royce, Ed.

Not done here, on purpose. The trailing roman-numeral reading in a name with no comma is stated by no rule; C1 states only the comma case. Measured on master:

  • John Smith V reads suffix 'V' and reports.
  • John Smith V. and John J. V read family 'V.' and 'V'.
  • John Smith v reads suffix with no report.
  • John V reads suffix and loses its family.

Stating that as a rule means deciding those edges, so it is left to a separate design question rather than written down as found.

Tests: the affected modules pass (7,767), and ruff is clean.

🤖 Generated with Claude Code

Four comments credited rules/S2 with an 'initial veto' or a 'numeral
fork' that no rule's statement holds, before the split or after it. The
comma case is rules/C1's one-character suffix word, read by what stands
before it; the others now name the predicates, _vocab.is_initial and
_vocab.is_trailing_numeral_suffix. A case note's 'item 5 of
decisions/S4', a numbered list in a gitignored spec, now names the
decisions/S4 entry it meant.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derek73 derek73 added the docs Documentation fixes and updates label Oct 18, 2026
@derek73 derek73 self-assigned this Oct 18, 2026
@derek73 derek73 added this to the 2.5 milestone Oct 18, 2026
@codecov

codecov Bot commented Oct 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.03%. Comparing base (c325bed) to head (5f504fd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #717   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files          46       46           
  Lines        4557     4557           
=======================================
  Hits         4513     4513           
  Misses         44       44           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@derek73
derek73 merged commit 958d252 into master Oct 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation fixes and updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant