Repository navigation
Point five stale S2 references at what exists - #717
Merged
Merged
Conversation
Four comments credited rules/S2 with an 'initial veto' or a 'numeral fork' that no rule's statement holds, before the split or after it. The comma case is rules/C1's one-character suffix word, read by what stands before it; the others now name the predicates, _vocab.is_initial and _vocab.is_trailing_numeral_suffix. A case note's 'item 5 of decisions/S4', a numbered list in a gitignored spec, now names the decisions/S4 entry it meant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #717 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 46 46
Lines 4557 4557
=======================================
Hits 4513 4513
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #716 (#682). Five references the S2 split's reviews found were already stale before the split. Comments only; no behavior change.
_pieces.py,test_group.py,cases.pycredited "rules/S2's initial veto", andtest_policy.py"rules/S2's numeral fork". No rule's statement holds either clause, before or after the split._piecesdocstring now cites that._vocab.is_initialand_vocab.is_trailing_numeral_suffix.cases.py's "row item 5 of decisions/S4" pointed at a numbered list in a gitignored spec. It now names the decisions/S4 entry it meant: 2026-09-15, THE COUNT REACHES THE LISTED SET TOO, which namesRoyce, Ed.Not done here, on purpose. The trailing roman-numeral reading in a name with no comma is stated by no rule; C1 states only the comma case. Measured on master:
John Smith Vreads suffix 'V' and reports.John Smith V.andJohn J. Vread family 'V.' and 'V'.John Smith vreads suffix with no report.John Vreads suffix and loses its family.Stating that as a rule means deciding those edges, so it is left to a separate design question rather than written down as found.
Tests: the affected modules pass (7,767), and ruff is clean.
🤖 Generated with Claude Code