Skip to content

Expect display-width padding in the expanded array test (cli_helpers 2.15.2) - #1653

Open
DiegoDAF wants to merge 1 commit into
dbcli:mainfrom
DiegoDAF:upstream/cli-helpers-2.15.2
Open

DiegoDAF wants to merge 1 commit into
dbcli:mainfrom
DiegoDAF:upstream/cli-helpers-2.15.2

Conversation

@DiegoDAF

Copy link
Copy Markdown
Contributor

Description

cli_helpers 2.15.2, released 2026-10-16, aligns vertical (expanded) output by display width (dbcli/cli_helpers#117). The header 配列 is two wide characters, so it now gets two fewer padding spaces, and test_format_array_output_expanded, which had the old misaligned output written down, fails on every build that installs the new release.

The expectation now has the aligned output, and cli_helpers >= 2.15.2 keeps the test from depending on which release gets installed: with 2.15.1 it fails, as it should, since that release misaligns.

Checklist

  • I have added this contribution to the changelog.rst.
  • I have added my name to the AUTHORS file (or it is already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install).
  • Please squash merge this pull request (uncheck if you would like us to merge as multiple commits)

On the third box: .pre-commit-config.yaml pins an older ruff-pre-commit than the one tox -e style installs, and the two disagree on formatting, so I ran ruff check and ruff format matching the CI instead, both clean.

cli_helpers 2.15.2, released 2026-10-16, aligns vertical output by
display width (dbcli/cli_helpers#117), so the header 配列, two wide
characters, gets two fewer padding spaces. The test had the old
misalignment written down and fails with the new release.

The expectation now has the aligned output, and cli_helpers >= 2.15.2
keeps the test from depending on which release is installed: 2.15.1
fails it, as it should, since it misaligns.
DiegoDAF added a commit to DiegoDAF/pgcli.daf that referenced this pull request Oct 16, 2026
@DiegoDAF DiegoDAF mentioned this pull request Oct 16, 2026
3 of 4 tasks

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant