Repository navigation
Preserve local objects when downloading onto the source - #2201
Open
zhechen-cs wants to merge 1 commit into
Open
zhechen-cs wants to merge 1 commit into
zhechen-cs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handle
shutil.SameFileErrorbefore ordinary copy failures in the local storage driver. Downloading an object onto itself still returnsFalse, but no longer deletes the source object during failure cleanup.The regression checks both an explicit source filename and its containing directory with a trailing separator, then verifies the stored contents and object metadata remain available.
Fixes #2200
Status
Ready for review.
Validation
trunkwithFileNotFoundErrorafter the source is deleted.git diff --checkpass for the changed files.Checklist