Repository navigation
Conversation
Signed-off-by: Vamsi-klu <nrvamsi13@gmail.com>
Vamsi-klu
marked this pull request as ready for review
October 17, 2026 11:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5109.
Skip a per-column sample table when the existing null-aware filter leaves no differing sampled rows. A column may differ globally while matching in every row selected by a small sample limit; its global statistics remain visible.
Tests cover the real DuckDB limit=1/2 case, nullable values, both NULL mismatch directions, aliases and composite keys, inherited Markdown rendering, and input-data preservation.
Suggested reviewers: erindru.
Test Plan
python -m pytest tests/core/test_console.py tests/core/test_table_diff.py -q -n 0 -p no:rerunfailures: 29 passed.make styleandmake fast-testpassed on this branch.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO