Skip to content

fix(vscode): support executable paths containing spaces - #6100

Open
Vamsi-klu wants to merge 3 commits into
SQLMesh:mainfrom
Vamsi-klu:fix/6093-vscode-exec-spaces
Open

Vamsi-klu wants to merge 3 commits into
SQLMesh:mainfrom
Vamsi-klu:fix/6093-vscode-exec-spaces

Conversation

@Vamsi-klu

@Vamsi-klu Vamsi-klu commented Sep 27, 2026 •

Copy link
Copy Markdown

Description

Fixes #6093.

  • Replace shell-based command construction with execFile(command, args) so executable paths and arguments containing spaces are passed intact.
  • Preserve ExecResult behavior for nonzero exits and spawn failures while continuing to reject cancellation with AbortError.
  • Pass uv and shared-environment warm-up arguments separately and add regression coverage for spaced paths, literal shell metacharacters, trace output, failures, and cancellation.

Test Plan

  • make style: all four checks passed.
  • make fast-test: all six phases passed; the main phase reported 2,699 passed and 6 skipped.
  • Root pnpm run lint: passed across the workspace.
  • Extension unit tests: 28 passed, including the shared-environment warm-up regression.
  • TypeScript checks and extension bundle: passed.
  • VSIX packaging: passed.
  • Packaged diagnostics browser tests: 10 passed with one worker.
  • Real interpreter warm-up from a path containing spaces: passed.

Checklist

  • I have run make style and fixed any issues
  • I have added tests for my changes (if applicable)
  • All existing tests pass (make fast-test)
  • My commits are signed off (git commit -s) per the DCO

Signed-off-by: Vamsi-klu <nrvamsi13@gmail.com>
@Vamsi-klu

Copy link
Copy Markdown
Author

@benfdking @georgesittas — could you review this? It touches the VS Code subprocess helper and E2E utilities you have previously worked on and reviewed.

Vamsi-klu and others added 2 commits October 12, 2026 18:43
Merge current main and adapt shared-environment warm-up to the executable and argument interface. Cover spaced interpreter paths and preserve import failure reporting.

Signed-off-by: Vamsi-klu <nrvamsi13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VSCode extension: execAsync builds an unquoted shell string, so any workspace path containing a space fails

1 participant