Repository navigation
feat: create a model from a tokenizer - #401
Merged
Merged
Conversation
[Medium impact] Adds new functions to initialize models from tokenizers. The PR appears safe to merge, with two non-blocking improvements worth making. Reviews (1) · Last reviewed commit: "mypy" · Reviewed by Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Pringled
approved these changes
Oct 17, 2026
Pringled
left a comment
Member
There was a problem hiding this comment.
One smoll thing but LGTM! I think some of the new tests could become part of existing tests but fine either way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found myself often creating random models from tokenizers, so I decided to add a function that just takes a tokenizer and then creates random vectors. This is useful, because the vocabulary creation/guards and checks around vocabulary were not available outside of distillation.
I added two functions:
The former takes a tokenizer name, the second takes an initialized tokenizer.