Repository navigation
Conversation
Server(None) is constructible from Python; close() then segfaulted in _unref via self._loop._servers. Return early when _loop is missing so invalid construction raises a clean error path instead of crashing. Fixes MagicStack#760
Author
|
Closing for now; may revisit later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uvloop.loop.Server(None)can be constructed from Python. Callingclose()then segfaulted in_unrefwhen discarding fromself._loop._servers.Guard
_unrefandclosewhen_loop is Noneso this invalid usage does not terminate the interpreter.Fixes #760
Test plan
from uvloop.loop import Server; Server(None).close()should not segfault