Repository navigation
feat(config): add renderingEnabledSupplier to disable rendering - #1344
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
jasmith-hs
marked this pull request as ready for review
October 17, 2026 11:19
rewaddell
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
renderingEnabledSupplier(Supplier<Boolean>) toJinjavaConfigso that consumers can turn off rendering for aJinjavainstance, for example as a kill switch, without rebuilding it. The supplier is checked every time rendering starts inJinjavaInterpreter. When it doesn't returntrue, aRenderingDisabledExceptionis thrown, andJinjava#renderForResultturns it into a FATALDISABLEDtemplate error.This description was authored by Claude Code.
BRAVE
Backwards Compatibility
() -> true, so existing behavior is unchangedTemplateErrorfactoryRollout and Rollback Plan
JinjavaConfig.newBuilder().withRenderingEnabledSupplier(...)Automated Testing
RenderingEnabledSupplierTestcovering the default setting, rendering on and off, therenderForResulterror shape,renderthrowing, toggling between renders, and the direct interpreter entry pointsmvnd clean verifypassesVerification
Expect Dependencies to Fail
REVIEWERS: Please review both the code changes and the answers above, and validate that they match the expectations for BRAVE
🤖 Generated with Claude Code