Repository navigation
Conversation
When the file row still exists but PostgreSQL lo_get fails with "large object … does not exist", map that to NotFound404 instead of leaking the database error as HTTP 500. Fixes 1Panel-dev#7356
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7356.
When a
filerow still exists but its PostgreSQL large object (loid) has already been removed,File.get_bytes()→lo_getraisesDatabaseError(large object … does not exist).FileSerializer.Operate.get()used to let that bubble up as HTTP 500 with the raw database message.This change catches that specific error and raises
NotFound404with a short “File content not found” message, matching the existing “File not found” path for a missing row. OtherDatabaseErrors are rethrown unchanged.Test plan
apps/oss/tests.py(MissingLargeObjectTests):NotFound404(status 404)DatabaseError→ still raisedFileSerializer.Operate.get(full MaxKB Django stack / Postgres not available in this environment).lo_unlink.AI assistance disclosure
An AI coding assistant helped implement the catch, the unit tests, and this PR description. I reviewed the diff and the local regression results above.